Dedicated method for creating circuit from op tree with EARLIEST strategy#5332
Merged
CirqBot merged 34 commits intoquantumlib:masterfrom Jul 11, 2022
Merged
Dedicated method for creating circuit from op tree with EARLIEST strategy#5332CirqBot merged 34 commits intoquantumlib:masterfrom
CirqBot merged 34 commits intoquantumlib:masterfrom
Conversation
This reverts commit 9c1d3ed.
dstrain115
reviewed
May 9, 2022
Collaborator
dstrain115
left a comment
dstrain115
left a comment
There was a problem hiding this comment.
Nice speedup! Looking forward to having this in. Was thinking of looking into this the other day and am now very happy that it is already taken care of!
I added some notes that this should have more commenting.
| else: | ||
| self.append(contents, strategy=strategy) | ||
|
|
||
| def _create_from_earliest(self, contents): |
Collaborator
There was a problem hiding this comment.
We may want to consider adding a docstring or other comments, especially since there are subtleties here in how to do earliest (with measurement keys, controlled ops, etc).
I certainly find it challenging to follow without comments.
Collaborator
Author
There was a problem hiding this comment.
Added comments and types. LMK what you think.
Collaborator
Author
|
@dstrain115 I updated the documentation. Should this be merged before 0.15? |
dstrain115
approved these changes
Jul 11, 2022
Collaborator
dstrain115
left a comment
dstrain115
left a comment
There was a problem hiding this comment.
Sorry, I lost track of this. Let's merge this!
Collaborator
Author
|
Merge label? I don't have authz |
mpharrigan
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
vtomole
reviewed
Aug 8, 2022
| ) | ||
| # limit index to 0..len(self._moments), also deal with indices smaller 0 | ||
| k = max(min(index if index >= 0 else len(self._moments) + index, len(self._moments)), 0) | ||
| for moment_or_op in moments_and_operations: |
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
…tegy (quantumlib#5332) We keep track of the latest moment that contains each qubit and measurement key. Then we know where to put each operation in constant time. We don't create the actual Moments until the very end, when we know where everything goes. Also added explicit key protocol impls for EigenGate, preempting the protocol from attempting a bunch of fallback options. On my laptop this speeds up creating circuits with EARLIEST strategy by almost infinity percent. (On my laptop, the circuit in the new test goes from 29.00s on master to 0.13s here).
4 tasks
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
…tegy (quantumlib#5332) We keep track of the latest moment that contains each qubit and measurement key. Then we know where to put each operation in constant time. We don't create the actual Moments until the very end, when we know where everything goes. Also added explicit key protocol impls for EigenGate, preempting the protocol from attempting a bunch of fallback options. On my laptop this speeds up creating circuits with EARLIEST strategy by almost infinity percent. (On my laptop, the circuit in the new test goes from 29.00s on master to 0.13s here).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We keep track of the latest moment that contains each qubit and measurement key. Then we know where to put each operation in constant time. We don't create the actual Moments until the very end, when we know where everything goes. Also added explicit key protocol impls for EigenGate, preempting the protocol from attempting a bunch of fallback options. On my laptop this speeds up creating circuits with EARLIEST strategy by almost infinity percent. (On my laptop, the circuit in the new test goes from 29.00s on master to 0.13s here).