Use np.complexfloating for dtypes that should be complex#5488
Merged
CirqBot merged 12 commits intoquantumlib:masterfrom Jun 23, 2022
Merged
Use np.complexfloating for dtypes that should be complex#5488CirqBot merged 12 commits intoquantumlib:masterfrom
CirqBot merged 12 commits intoquantumlib:masterfrom
Conversation
dabacon
added
the
kind/health
Collaborator
Author
mpharrigan
approved these changes
Jun 22, 2022
Collaborator
mpharrigan
left a comment
mpharrigan
left a comment
There was a problem hiding this comment.
cool. much better type info
| prng=mock_prng, | ||
| initial_state=np.copy(state), | ||
| dtype=state.dtype, | ||
| dtype=cast(Type[np.complexfloating], state.dtype), |
Collaborator
There was a problem hiding this comment.
can change this cast to an assert earlier?
dabacon
added
the
BREAKING CHANGE
dabacon
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
…5488) This changes the type signature for dtypes that should only be `np.complex64` or `np.complex128`. There are also dtypes in `qis.states.py` but I've not changed these over, as they are often called the `dtype` of a `np.array`, and so they will often need to be cast. This fixes some `check/mypy --next` errors. Technically a breaking change in type signature (more restrictive), but we yell when types are not complex.
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
…5488) This changes the type signature for dtypes that should only be `np.complex64` or `np.complex128`. There are also dtypes in `qis.states.py` but I've not changed these over, as they are often called the `dtype` of a `np.array`, and so they will often need to be cast. This fixes some `check/mypy --next` errors. Technically a breaking change in type signature (more restrictive), but we yell when types are not complex.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the type signature for dtypes that should only be
np.complex64ornp.complex128.There are also dtypes in
qis.states.pybut I've not changed these over, as they are often called thedtypeof anp.array, and so they will often need to be cast.This fixes some
check/mypy --nexterrors.Technically a breaking change in type signature (more restrictive), but we yell when types are not complex.