Remove deprecated ArithmeticOperation

[daxfohl]

@MichaelBroughton

[MichaelBroughton]

LGTM after fix on shors.ipynb

[daxfohl]

Oof, that looks nontrivial (at least for me -- I'd need to ramp up on how to work with ipynb files, which I don't have time for right now). Anybody who wants to fork from here, I know there's a shor.py that probably had the same change when I originally deprecated ArithmeticOperation: https://github.com/quantumlib/Cirq/pull/4702/files#diff-9d5e940cf487ce1f28d94c8a32b7c4c2a5da812e72b48aa6e5db733e3f511066

[daxfohl]

Closing PR since I won't be able to finish it.

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[daxfohl]

@MichaelBroughton I figured out how to do this. However I'm getting an error saying cirq.ArithmeticGate is not defined. But it is. And it works locally. Any idea?

[pavoljuhas]

However I'm getting an error saying cirq.ArithmeticGate is not defined. But it is. And it works locally. Any idea?

I am new to the notebook test machinery, but the test may be running with a released cirq.
Perhaps the shor.ipynb notebook needs to be added to NOTEBOOKS_DEPENDING_ON_UNRELEASED_FEATURES -

Cirq/dev_tools/notebooks/isolated_notebook_test.py

Lines 43 to 59 in df99587

	NOTEBOOKS_DEPENDING_ON_UNRELEASED_FEATURES: List[str] = [
	# Hardcoded qubit placement
	'docs/google/qubit-placement.ipynb',
	# get_qcs_objects_for_notebook
	'docs/noise/calibration_api.ipynb',
	'docs/tutorials/google/colab.ipynb',
	'docs/tutorials/google/identifying_hardware_changes.ipynb',
	'docs/tutorials/google/echoes.ipynb',
	'docs/noise/floquet_calibration_example.ipynb',
	'docs/tutorials/google/spin_echoes.ipynb',
	'docs/tutorials/google/start.ipynb',
	'docs/tutorials/google/visualizing_calibration_metrics.ipynb',
	'docs/noise/qcvv/xeb_calibration_example.ipynb',
	'docs/named_topologies.ipynb',
	'docs/representing_noise.ipynb',
	'docs/start/intro.ipynb',
	]

[daxfohl]

@MichaelBroughton @pavoljuhas It turns out this is not ready to be removed. #4702 was started in November but did not get merged until May, which was after 14.1 went out. These deprecations need to be bumped to 0.16 instead.

[daxfohl]

@MichaelBroughton v0.15 is out, so reopening.