Skip to content

Remove ops.Moment deprecation. #5682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CirqBot merged 2 commits into from
Jul 8, 2022
Merged

Remove ops.Moment deprecation. #5682

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c7471a
Remove ops.Moment deprecation.
MichaelBroughton Jul 7, 2022
53908cc
Merge branch 'master' into moment_dep
CirqBot Jul 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions cirq-core/cirq/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -701,19 +701,4 @@

from cirq import contrib

# deprecate cirq.ops and related attributes

from cirq import _compat

_compat.deprecated_submodule(
new_module_name='cirq.circuits.moment',
old_parent='cirq.ops',
old_child='moment',
deadline='v0.16',
create_attribute=True,
)

ops.Moment = Moment # type: ignore
_compat.deprecate_attributes('cirq.ops', {'Moment': ('v0.16', 'Use cirq.circuits.Moment instead')})

# pylint: enable=wrong-import-position
12 changes: 0 additions & 12 deletions cirq-core/cirq/circuits/moment_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,18 +18,6 @@
import cirq
import cirq.testing

ALLOW_DEPRECATION_IN_TEST = 'ALLOW_DEPRECATION_IN_TEST'
Copy link
Copy Markdown
Collaborator

@vtomole vtomole Jul 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused variable?

Copy link
Copy Markdown
Collaborator Author

@MichaelBroughton MichaelBroughton Jul 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a hint to allow for deprecated functionality in the test module.



def test_deprecated_submodule():
with cirq.testing.assert_deprecated("Use cirq.circuits.moment instead", deadline="v0.16"):
_ = cirq.ops.moment.Moment


def test_deprecated_attribute_in_cirq_ops():
with cirq.testing.assert_deprecated("Use cirq.circuits.Moment instead", deadline="v0.16"):
_ = cirq.ops.Moment


def test_validation():
a = cirq.NamedQubit('a')
Expand Down