Skip to content

remove 2 deprecated create_device_proto_* methods for v0.16 release#5704

Merged
CirqBot merged 11 commits intoquantumlib:masterfrom
kmlau:rm_deprecated_create_proto_methods
Jul 12, 2022
Merged

remove 2 deprecated create_device_proto_* methods for v0.16 release#5704
CirqBot merged 11 commits intoquantumlib:masterfrom
kmlau:rm_deprecated_create_proto_methods

Conversation

@kmlau
Copy link
Copy Markdown
Collaborator

@kmlau kmlau commented Jul 9, 2022

This is the 1st task under "Remove deprecations" section in #5050

@kmlau kmlau requested review from a team, cduck, verult, vtomole and wcourtney as code owners July 9, 2022 00:37
@CirqBot CirqBot added the size: L 250< lines changed <1000 label Jul 9, 2022
Copy link
Copy Markdown
Collaborator

@verult verult left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm chatting with @maffoo to verify that it's OK to merge removal PRs before server-side changes are in for Cirq 0.15 deprecations. Until then let's hold off on merging

[cirq_google.FSIM_GATESET],
known_devices._SYCAMORE_DURATIONS_PICOS,
)
device_info, _ = _create_device_spec_with_horizontal_couplings()
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test can be removed, since we no longer need to be backward compatible with SerializableGateSet

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@verult
Copy link
Copy Markdown
Collaborator

verult commented Jul 11, 2022

Synced with @maffoo - we'll merge all the removals before updating Pyle.

@verult verult added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jul 12, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jul 12, 2022
@CirqBot CirqBot merged commit 6e52f54 into quantumlib:master Jul 12, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jul 12, 2022
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: L 250< lines changed <1000

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants