Improve Fourier Checking tutorial#5708
Merged
CirqBot merged 9 commits intoquantumlib:masterfrom Jul 12, 2022
Merged
Conversation
- Change Foxtail to Sycamore since Foxtail is deprecated. - Add some clarification that instructions are for linux.
- Miscellaenous fixes for Fourier Checking - Fix top block was code not text - Fix latex blocks in various places - Improve docstrings and typing for functions - A few miscellaenous wording improvements.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
dabacon
reviewed
Jul 12, 2022
| @@ -32,12 +32,10 @@ | |||
| ] | |||
Collaborator
There was a problem hiding this comment.
Collaborator
Author
There was a problem hiding this comment.
I think this is an artifact of ReviewNB. I don't see anything in the source that could cause this, it doesn't appear in the github viewer, and, if you hide previous version in ReviewNB, it disappears. I will commit this and double-check that it doesn't show up on the website, but I think it is just a reviewnb glitch.
dabacon
approved these changes
Jul 12, 2022
Collaborator
dabacon
left a comment
dabacon
left a comment
There was a problem hiding this comment.
One line still looks messed to me but otherwise LGTM
dstrain115
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
- Miscellaenous fixes for Fourier Checking - Fix top block was code not text - Fix latex blocks in various places - Improve docstrings and typing for functions - A few miscellaenous wording improvements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.