Enable testing of cirq_google notebooks.#5766
Merged
CirqBot merged 14 commits intoquantumlib:masterfrom Sep 3, 2022
Merged
Conversation
Collaborator
dstrain115
commented
Jul 14, 2022
dstrain115
commented
- Removing outputs and skip notebooks for cirq_google
- cirq_google notebooks should run with virtual Engine objects.
- Removing outputs and skip notebooks for cirq_google - cirq_google notebooks _should_ run with virtual Engine objects.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
dstrain115
requested review from
a team,
cduck,
verult,
vtomole and
wcourtney
as code owners
Collaborator
Author
|
This enables testing of (some) of the cirq_google notebooks. Please let me know what you think. Please comment also if you think the tests that exercise "from google.colab import auth" are too hacky. Worst case, I can mark those lines as coverage ignore. |
dstrain115
changed the title
Collaborator
|
Here is another way of temporarily mocking the google.colab module - pavoljuhas@36be3f4. If that looks good, you can pull it in with |
Collaborator
Author
|
@pavoljuhas It does look good to me! Pulled it in. Thanks! |
pavoljuhas
reviewed
Sep 1, 2022
| "outputs": [], | ||
| "source": [ | ||
| "valid_qubit = device.qubits[0]\n", | ||
| "valid_qubit = sorted(list(device.metadata.qubit_set))[0]\n", |
Collaborator
There was a problem hiding this comment.
Nit - list(...) can be removed, because sorted() can take any iterable.
pavoljuhas
approved these changes
Sep 1, 2022
Collaborator
pavoljuhas
left a comment
pavoljuhas
left a comment
There was a problem hiding this comment.
LGTM after nit cleanup.
dstrain115
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
- Removing outputs and skip notebooks for cirq_google - cirq_google notebooks _should_ run with virtual Engine objects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.