Use pytest-randomly for reproducible random test parameters#5868
Merged
CirqBot merged 16 commits intoquantumlib:masterfrom Sep 20, 2022
Merged
Use pytest-randomly for reproducible random test parameters#5868CirqBot merged 16 commits intoquantumlib:masterfrom
CirqBot merged 16 commits intoquantumlib:masterfrom
Conversation
These instances of seeding do not appear to affect test results.
No need to parametrize for a single set of values, let us set them in the test body instead.
Replaced by pytest-randomly. The seed from pytest-randomly appears to be in effect at the test discovery stage and makes RNG-generated test parameters reproducible.
Avoid using `pytest --quiet` which disables pytest-randomly hook that configures consistent seeding for parallel test jobs. Reverts quantumlib#1825.
These tests are tied to the zero seed of numpy RNG.
Collaborator
Author
|
@vtomole - can you PTAL at this PR? Let me know if there are any questions. Thanks! |
vtomole
approved these changes
Sep 20, 2022
Collaborator
vtomole
left a comment
vtomole
left a comment
There was a problem hiding this comment.
Thanks for the ping. Forgot to submit review: LGTM.
Collaborator
|
What happened to #4788 (comment)? |
Collaborator
Collaborator
Author
I believe I was checking the tests with check/pytest script which was executing In short, |
pavoljuhas
added
the
automerge
Contributor
|
Automerge cancelled: A status check is failing. |
CirqBot
removed
the
automerge
pavoljuhas
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
…ib#5868) - Require pytest-randomly for the testing to ensure RNG-generated test parameters are consistent across parallel test jobs. - Remove check/pytest option --actually-quiet which disables pytest-randomly hook for seeding parallel test jobs. - Remove `CIRQ_TESTING_RANDOM_SEED` as it is not needed anymore. - Remove RNG seeding in the tests where it seems redundant. - Clean up one instance of unnecessary test parametrization. This upholds quantumlib#4787 and replaces quantumlib#4788. Reverts quantumlib#1825 and obsoletes quantumlib#1826.
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
…ib#5868) - Require pytest-randomly for the testing to ensure RNG-generated test parameters are consistent across parallel test jobs. - Remove check/pytest option --actually-quiet which disables pytest-randomly hook for seeding parallel test jobs. - Remove `CIRQ_TESTING_RANDOM_SEED` as it is not needed anymore. - Remove RNG seeding in the tests where it seems redundant. - Clean up one instance of unnecessary test parametrization. This upholds quantumlib#4787 and replaces quantumlib#4788. Reverts quantumlib#1825 and obsoletes quantumlib#1826.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parameters are consistent across parallel test jobs.
hook for seeding parallel test jobs.
CIRQ_TESTING_RANDOM_SEEDas it is not needed anymore.This upholds #4787 and replaces #4788.
Reverts #1825 and obsoletes #1826.