Fix failing imports from httpcore#5891
Merged
CirqBot merged 3 commits intoquantumlib:masterfrom Sep 27, 2022
Merged
Conversation
The `httpcore._types` module was removed in encode/httpcore@f9b9391.
Indirect dependency chain on httpcore: - pyquil (==3.2.0) requires qcs-api-client (>=0.20.13,<0.22.0) - qcs-api-client (==0.21.2) requires (httpx (>=0.23.0,<0.24.0) - httpx (==0.23.0) requires httpcore (>=0.15.0,<0.16.0)
Use httpx instead.
pavoljuhas
changed the title
tanujkhattar
approved these changes
Sep 27, 2022
Collaborator
tanujkhattar
left a comment
tanujkhattar
left a comment
There was a problem hiding this comment.
Thanks for debugging this!
cc @erichulburd
pavoljuhas
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
Refactor `test_rigetti_qcs_service_api_call()` to use public API from httpx instead of private API from httpcore which changed. Also require pyquil>=3.2.0 to ensure httpx and httpcore include API change at httpcore==0.14.0, encode/httpcore@f9b9391. Note: pyquil creates indirect dependency on httpcore as follows: - pyquil (==3.2.0) requires qcs-api-client (>=0.20.13,<0.22.0) - qcs-api-client (==0.21.2) requires httpx (>=0.23.0,<0.24.0) - httpx (==0.23.0) requires httpcore (>=0.15.0,<0.16.0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor
test_rigetti_qcs_service_api_call()to use public API from httpx insteadof private API from httpcore which changed.
Also require pyquil>=3.2.0 to ensure httpx and httpcore include API change at httpcore==0.14.0,
encode/httpcore@f9b9391.
Note: pyquil creates indirect dependency on httpcore as follows: