Optimize circuit/moment resolution to reuse instances if possible#5894
Merged
Optimize circuit/moment resolution to reuse instances if possible#5894
Conversation
tanujkhattar
approved these changes
Sep 28, 2022
Collaborator
tanujkhattar
left a comment
tanujkhattar
left a comment
There was a problem hiding this comment.
This is great. Thanks!
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
pavoljuhas
added a commit
to dv8081/Cirq
that referenced
this pull request
Nov 19, 2024
Verify if the optimization from quantumlib#5894 is covered by unit tests. Here we make such test deliberately fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cirq.Momentresolvable, and don't allocate a new instance if nothing changes during resolution._resolve_parameter_implementations onCircuitandFrozenCircuit._from_momentsto avoid constructor overhead when creating resolved circuits.selfif nothing has changed in circuit during resolution, to avoid unnecessary allocations.