Fix test failure on differing precision of float in proto string#5911
Merged
CirqBot merged 2 commits intoquantumlib:masterfrom Oct 6, 2022
Merged
Conversation
Problem: CI Pytest MacOS (3.10) fails because float value is output with a lower precision than in expected textproto. (https://github.com/quantumlib/Cirq/actions/runs/3192951160/jobs/5211002538) Solution: Update expected textproto to a lower precision and replace high-precision values in the tested string.
pavoljuhas
requested review from
a team,
cduck,
verult,
vtomole and
wcourtney
as code owners
maffoo
reviewed
Oct 6, 2022
| layer_str = str(new_layer) | ||
| # Fix precision issues | ||
| layer_str = re.sub(r'0.004999\d+', '0.005', layer_str) | ||
| layer_str = re.sub(r'\b0.78539818\d*', '0.7853982', layer_str) |
Contributor
There was a problem hiding this comment.
Could we fix this by setting theta on the fsim gate to a different value that can be exactly represented by floats, e.g. theta=0.5? We could do something similar on fatol to avoid the need for the previous string substitution hack, setting it to something like 2**-7 == 0.0078125 instead of 0.005.
Collaborator
Author
There was a problem hiding this comment.
Sure, that is nicer than substitution. Done in 6148c40.
maffoo
approved these changes
Oct 6, 2022
pavoljuhas
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
…ntumlib#5911) Problem: CI Pytest MacOS (3.10) fails because float value is output with a lower precision than in the expected textproto, https://github.com/quantumlib/Cirq/actions/runs/3192951160/jobs/5211002538. Solution: Test with parameters that have exact decimal representation, theta = 0.75, fatol = xatol = 2**-7 = 0.0078125.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: CI Pytest MacOS (3.10) fails because float value is output with
a lower precision than in the expected textproto,
https://github.com/quantumlib/Cirq/actions/runs/3192951160/jobs/5211002538.
Solution: Test with parameters that have exact decimal representation,
theta = 0.75, fatol = xatol = 2**-7 = 0.0078125.