-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix sympy error #5930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sympy error #5930
Changes from 6 commits
eb59ca2
7bff7a0
28e3036
be327af
966d380
e4874d3
d6d2d3b
205e72b
592b4e1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -244,9 +244,11 @@ def _resolved_value_(self): | |
| c = sympy.Symbol('c') | ||
| r = cirq.ParamResolver({a: foo, b: bar, c: baz}) | ||
| assert r.value_of(a) is foo | ||
| assert r.value_of(b) is b | ||
| assert r.value_of(c) == 'Baz' | ||
|
|
||
| with pytest.raises(ValueError, match='Could not resolve parameter b'): | ||
| _ = r.value_of(b) | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we should move this to a separate test function marked with a strict xfail, for example, @pytest.mark.xfail(reason='this test requires sympy 1.12', strict=True)
def test_custom_value_not_implemented():
...When the new sympy is released, the strict xfail will produce a CI failure
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good idea done. |
||
|
|
||
|
|
||
| def test_compose(): | ||
| """Tests that cirq.resolve_parameters on a ParamResolver composes.""" | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update to sympy.SympifyError?