Enable CI check with numpy-1.24.2 for #5991#6028
Closed
pavoljuhas wants to merge 5 commits intoquantumlib:masterfrom
Closed
Enable CI check with numpy-1.24.2 for #5991#6028pavoljuhas wants to merge 5 commits intoquantumlib:masterfrom
pavoljuhas wants to merge 5 commits intoquantumlib:masterfrom
Conversation
Temporarily upgrade to numpy-1.24.2 to enable CI testing of quantumlib#5991. Restrict CI-tests to Python 3.8 only which permits installation of numpy-1.24.2 and numba. Note numba is not yet compatible with numpy-1.24 and its import raises SystemError exception SystemError: initialization of _internal failed without raising an exception Here we also add intentionally failing CI check to ensure this commit is not accidentally merged to master. Please revert this commit before merging the pull-request.
pavoljuhas
force-pushed
the
core-np1.24-with-np1.24
branch
from
7197575 to
90780ec
Compare
This reverts commit 90780ec.
Also fail when attributes are used in eval expressions. This prepares for upgrade to NumPy 1.24 which removes deprecated names.
Collaborator
Author
|
withdrawn. CI-checks not feasible, numba is not yet available for numpy-1.24. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT SUBMIT
Temporary CI checks related to compatibility with NumPy-1.24.