Ensure compatible version of numpy in isolated_notebook_test.py#6038
Conversation
Keep numpy version in the isolated Python environment at 1.23 as numpy-1.24 is incompatible with cirq and numba. Fixes stuck notebook tests which import numba. Related to quantumlib#5967
|
ping - can somebody PTAL? |
viathor
left a comment
There was a problem hiding this comment.
This PR LGTM, but as a general reflection: it replicates the constraints in requirements.txt, so I'm wondering whether there is a way to avoid the duplication?
Ack. To my understanding this list of packages should simulate the jupyter/colab environment of a user running the examples for the first time. The cirq is installed as a part of the notebook execution in that environment later. BTW, the |
Keep numpy version in the isolated Python environment at 1.23 as
numpy-1.24 is incompatible with cirq and numba.
Fixes stuck notebook tests which import numba.
Related to #5967