Skip to content

Add weekly CI workflow to test all notebooks #6046

Merged
pavoljuhas merged 3 commits intoquantumlib:masterfrom
xXnathankerrXx:weekly_tests
Apr 11, 2023
Merged

Add weekly CI workflow to test all notebooks #6046
pavoljuhas merged 3 commits intoquantumlib:masterfrom
xXnathankerrXx:weekly_tests

Conversation

@xXnathankerrXx
Copy link
Copy Markdown
Contributor

Verified "changed notebooks" and "all notebooks" tests run when pytest is called with the respective mark and skipped otherwise.

I didn't find a good way to test the scheduled Action. Let me know if there's a good way.

Fixes #6037

@xXnathankerrXx xXnathankerrXx requested review from a team, cduck and vtomole as code owners March 31, 2023 02:51
@CirqBot CirqBot added the size: M 50< lines changed <250 label Mar 31, 2023
Copy link
Copy Markdown
Collaborator

@pavoljuhas pavoljuhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing this!
Looks good to go to me after a few small updates.

Comment thread .github/workflows/ci-weekly.yml Outdated
Comment thread dev_tools/notebooks/isolated_notebook_test.py Outdated
Comment thread dev_tools/notebooks/isolated_notebook_test.py Outdated
@xXnathankerrXx
Copy link
Copy Markdown
Contributor Author

Thanks for the review. Made the requested changes and rebased against master.

Copy link
Copy Markdown
Collaborator

@pavoljuhas pavoljuhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: M 50< lines changed <250

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI - run weekly isolated_notebook_test for all notebooks

3 participants