Skip to content

Fix matplotlib deprecation warning #6072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dstrain115 merged 3 commits into from
Apr 21, 2023
Merged

Fix matplotlib deprecation warning #6072

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
49e84d9
Fix matplotlib deprecation warning
dstrain115 Apr 20, 2023
9b11480
Fix for better deprecation
dstrain115 Apr 20, 2023
6369d78
Merge branch 'master' into fix_mpl_deprectation
CirqBot Apr 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cirq-core/cirq/vis/heatmap_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ def test_cell_colors(ax, colormap_name):
)
_, mesh = random_heatmap.plot(ax)

colormap = mpl.cm.get_cmap(colormap_name)
colormap = mpl.colormaps.get_cmap(colormap_name)
for path, facecolor in zip(mesh.get_paths(), mesh.get_facecolors()):
vertices = path.vertices[0:4]
row = int(round(np.mean([v[1] for v in vertices])))
Expand Down Expand Up @@ -218,7 +218,7 @@ def __format__(self, format_string):

_, mesh = random_heatmap.plot(ax)

colormap = mpl.cm.get_cmap(colormap_name)
colormap = mpl.colormaps.get_cmap(colormap_name)
Copy link
Copy Markdown
Collaborator

@viathor viathor Apr 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional: Issue matplotlib/matplotlib#20853 suggests we should perhaps just say

colormap = mpl.colormaps[colormap_name]

Copy link
Copy Markdown
Collaborator Author

@dstrain115 dstrain115 Apr 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Maybe this will work in python 3.7 too.

for path, facecolor in zip(mesh.get_paths(), mesh.get_facecolors()):
vertices = path.vertices[0:4]
row = int(round(np.mean([v[1] for v in vertices])))
Expand Down