Access _row and _col attributes directly in GridQubit instead of using properties#6075
Merged
Access _row and _col attributes directly in GridQubit instead of using properties#6075
_row and _col attributes directly in GridQubit instead of using properties#6075Conversation
maffoo
changed the title
_row and _col attributes directly in GridQubit instead of using properties_row and _col attributes directly in GridQubit instead of using properties
viathor
approved these changes
Apr 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
self._rowandself._colattributes directly instead of properties in the internals of these classes provides a significant speedup, especially since these classes are heavily used. On an internal benchmark, this reduced the total time spent inGridQubit.__eq__from 20.8s down to 5.7s, a 3.6x speedup.There are other optimizations we might be able to make in the future, for example by "de-virtualizing" more methods to not rely on generic implementations in the base class, as we have already done for
GridQubit.__eq__itself, but for now this provides a welcome performance boost.