Remove deprecated argument of pyplot.stem#6086
Merged
pavoljuhas merged 2 commits intoquantumlib:masterfrom May 8, 2023
Merged
Conversation
`use_line_collection` is deprecated and defaults to `True` anyway. Prevent deprecation messages from showing up at https://quantumai.google/cirq/experiments/fourier_checking
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Collaborator
Author
|
Requires #6087 to pass the CI. |
viathor
reviewed
May 8, 2023
Collaborator
viathor
left a comment
viathor
left a comment
There was a problem hiding this comment.
Here's what I've found:
use_line_collectionused to default toFalse. The default changed toTruein matplotlib 3.3.0, see release notes.use_line_collectionis deprecated since matplotlib 3.6.0, see documentation.- We depend on matplotlib ~3.0, see requirements.txt.
Perhaps we should upgrade matplotlib dependency first?
Collaborator
Author
Thank you for careful checking. The return value from the touched stem calls is not used. |
viathor
approved these changes
May 8, 2023
Collaborator
viathor
left a comment
viathor
left a comment
There was a problem hiding this comment.
Fair enough. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use_line_collectionis deprecated and defaults toTrueanyway.Prevent deprecation messages from showing up at
https://quantumai.google/cirq/experiments/fourier_checking