Conversation
- Adds optional metadata attribute to Linspace and Points. - This will be used to adjust device parameters via sweep. See https://tinyurl.com/cirq-sweep-metadata-public for RFC.
maffoo
left a comment
There was a problem hiding this comment.
Minor comments, then LGTM
|
Should probably add metadata on |
Co-authored-by: Matthew Neeley <mneeley@gmail.com>
Co-authored-by: Matthew Neeley <mneeley@gmail.com>
Co-authored-by: Matthew Neeley <mneeley@gmail.com>
Co-authored-by: Matthew Neeley <mneeley@gmail.com>
Co-authored-by: Matthew Neeley <mneeley@gmail.com>
Co-authored-by: Matthew Neeley <mneeley@gmail.com>
|
Note that in the |
|
Ok, thanks for the corrections. I will save ListSweep for a follow-up PR. I want to give it a bit more though. |
* Add metadata to sweeps - Adds optional metadata attribute to Linspace and Points. - This will be used to adjust device parameters via sweep. See https://tinyurl.com/cirq-sweep-metadata-public for RFC. Co-authored-by: Matthew Neeley <mneeley@gmail.com>
See https://tinyurl.com/cirq-sweep-metadata-public for RFC.