Changed simulators fallback to decompose_once and removed ancilla support from DensityMatrixSimulator#6127
Conversation
… qubit allocation within decompose
strat_act_on_from_apply_decompose and improve support for qubit allocation within decompose
|
The title of the PR doesn't really match the content of the PR, how about "Changed simulators' fallback to does having DensityMatrixSimulator support ancillas block cirq-ft ? nit: this PR is 2 in 1: the first a partial reversal of #6108 to remove the ancilla support from |
strat_act_on_from_apply_decompose and improve support for qubit allocation within decomposedecompose_once and removed ancilla support from DensityMatrixSimulator
|
Updated the title.
No.
Hmm, I'll let people take a look at it as is for a bit and I can split if it's getting hard to review. |
|
LGTM. pending review from @senecameeks |
|
@NoureldinYosri Can you LGTM with an approval to merge? I'll ping Seneca separately to take a look in the meantime. |
senecameeks
left a comment
There was a problem hiding this comment.
Reviewed, looks good!
…upport from `DensityMatrixSimulator` (quantumlib#6127) * Fix bugs in strat_act_on_from_apply_decompose and improve support for qubit allocation within decompose * Revert unrelated mypy change * Fix mypy types and remove context argument from strat_act_on_from_apply_decompose * Fix mypy error * Update docstrings
See #6081 (comment) for a detailed description. Tl;Dr is as follows:
strat_act_on_from_apply_decomposeandSimulationStatewhich were introduced as part of Update Density Matrix and State Vector Simulators to work when an operation allocates new qubits as part of its decomposition #6108