Skip to content

Remove temporary directories after test done#6236

Merged
pavoljuhas merged 2 commits intoquantumlib:masterfrom
shawn-peng:test/clean_temp_dirs
Aug 18, 2023
Merged

Remove temporary directories after test done#6236
pavoljuhas merged 2 commits intoquantumlib:masterfrom
shawn-peng:test/clean_temp_dirs

Conversation

@shawn-peng
Copy link
Copy Markdown
Contributor

  • remove temporary isolated venv after isolated notebook/packaging test done

  • remove temporary venv after cloned env test done

  • remove temporary directories for figures after heatmap testings

Fix pytest and TMPDIR housekeeping (#6036)

* remove temporary isolated venv after isolated notebook/packaging test done

* remove temporary venv after cloned env test done

* remove temporary directories for figures after heatmap testings

Fix pytest and TMPDIR housekeeping (quantumlib#6036)
@shawn-peng shawn-peng requested review from a team, cduck and vtomole as code owners August 9, 2023 21:40
@shawn-peng shawn-peng requested a review from maffoo August 9, 2023 21:40
@google-cla
Copy link
Copy Markdown

google-cla bot commented Aug 9, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@CirqBot CirqBot added the Size: XS <10 lines changed label Aug 9, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 10, 2023

Codecov Report

Patch coverage: 75.00% and no project coverage change.

Comparison is base (30fa6f5) 97.38% compared to head (0150b78) 97.38%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6236   +/-   ##
=======================================
  Coverage   97.38%   97.38%           
=======================================
  Files        1116     1116           
  Lines       96110    96118    +8     
=======================================
+ Hits        93594    93604   +10     
+ Misses       2516     2514    -2     
Files Changed Coverage Δ
dev_tools/notebooks/isolated_notebook_test.py 64.61% <50.00%> (-0.47%) ⬇️
dev_tools/packaging/isolated_packages_test.py 60.00% <50.00%> (-1.12%) ⬇️
cirq-core/cirq/vis/heatmap_test.py 98.02% <100.00%> (+0.01%) ⬆️
dev_tools/cloned_env_test.py 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pavoljuhas pavoljuhas self-requested a review August 16, 2023 17:16
Copy link
Copy Markdown
Collaborator

@pavoljuhas pavoljuhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@pavoljuhas pavoljuhas enabled auto-merge (squash) August 18, 2023 07:07
@pavoljuhas pavoljuhas merged commit 95cb43f into quantumlib:master Aug 18, 2023
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
* remove temporary isolated venv after isolated notebook/packaging test done

* remove temporary venv after cloned env test done

* remove temporary directories for figures after heatmap testings

Fixes quantumlib#6036
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Size: XS <10 lines changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants