Support the deprecated_parameter decorator for asynchronous functions.#6247
Merged
pavoljuhas merged 2 commits intoquantumlib:masterfrom Aug 16, 2023
Merged
Conversation
Contributor
Author
|
This feature is necessary because I need to deprecate the parameter |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #6247 +/- ##
=======================================
Coverage 97.38% 97.38%
=======================================
Files 1116 1116
Lines 96076 96100 +24
=======================================
+ Hits 93564 93588 +24
Misses 2512 2512
☔ View full report in Codecov by Sentry. |
pavoljuhas
requested changes
Aug 16, 2023
Collaborator
pavoljuhas
left a comment
pavoljuhas
left a comment
There was a problem hiding this comment.
Let us require the wrapped function to look like a coroutine.
Otherwise LGTM.
pavoljuhas
approved these changes
Aug 16, 2023
verult
approved these changes
Aug 16, 2023
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
quantumlib#6247) * Support the deprecated_parameter decorator for asynchronous functions. * Add assert iscoroutine to async_deprecated_parameter test --------- Co-authored-by: Jose Urruticoechea <urruti@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.