Support the new quantum engine processor_selector in engine_client#6254
Merged
verult merged 18 commits intoquantumlib:masterfrom Aug 28, 2023
Merged
Support the new quantum engine processor_selector in engine_client#6254verult merged 18 commits intoquantumlib:masterfrom
verult merged 18 commits intoquantumlib:masterfrom
Conversation
jurruti
requested review from
a team,
cduck,
verult,
vtomole and
wcourtney
as code owners
wcourtney
requested changes
Aug 22, 2023
verult
requested changes
Aug 23, 2023
Collaborator
verult
left a comment
verult
left a comment
There was a problem hiding this comment.
First pass, haven't looked at tests yet
jurruti
force-pushed
the
quantum_engine
branch
from
f7b7e4f to
413a7f5
Compare
jurruti
force-pushed
the
quantum_engine
branch
from
413a7f5 to
b905657
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #6254 +/- ##
=======================================
Coverage 97.60% 97.60%
=======================================
Files 1116 1116
Lines 95848 95911 +63
=======================================
+ Hits 93556 93618 +62
- Misses 2292 2293 +1
☔ View full report in Codecov by Sentry. |
verult
approved these changes
Aug 25, 2023
verult
approved these changes
Aug 25, 2023
added 2 commits
August 28, 2023 03:20
wcourtney
approved these changes
Aug 28, 2023
Collaborator
wcourtney
left a comment
wcourtney
left a comment
There was a problem hiding this comment.
LGTM % a couple of nits. Thanks!
| ) | ||
|
|
||
|
|
||
| def _fix_create_job_processor_id_args_and_kwargs(args, kwargs): |
Collaborator
There was a problem hiding this comment.
Nit: omit "args_and_kwargs" from the name since they're already in the parameters list.
Also - since this is intended only to be used by the "rewrite" clause of the @deprecated_parameter, consider using that nomenclature and describing the action of the method, eg. rewrite_processor_ids_to_processor_id
Contributor
Author
|
In the last few commits I added the rewrite function to the deprecated parameter decorator. Now we only get requests for the quantum engine where |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The update is no longer a breaking change. Note that I force pushed (because the refactor was quite heavy), so most comments from the first round are outdated.