Skip to content

Add serialization support for InsertionNoiseModel#6282

Merged
vtomole merged 9 commits intoquantumlib:masterfrom
suyashdamle:json
Sep 14, 2023
Merged

Add serialization support for InsertionNoiseModel#6282
vtomole merged 9 commits intoquantumlib:masterfrom
suyashdamle:json

Conversation

@suyashdamle
Copy link
Copy Markdown
Contributor

@suyashdamle suyashdamle commented Sep 7, 2023

  1. Add _json_dict and _from_json_dict_ magic functions to support
  2. Add InsertionNoiseModel in resolver cache

Fixes #6249

@suyashdamle suyashdamle requested review from a team, cduck and vtomole as code owners September 7, 2023 03:54
@CirqBot CirqBot added the size: S 10< lines changed <50 label Sep 7, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 7, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (cf005c2) 97.88% compared to head (f88e127) 97.88%.

❗ Current head f88e127 differs from pull request most recent head 08e8ab3. Consider uploading reports for the commit 08e8ab3 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6282      +/-   ##
==========================================
- Coverage   97.88%   97.88%   -0.01%     
==========================================
  Files        1104     1104              
  Lines       95819    95771      -48     
==========================================
- Hits        93794    93746      -48     
  Misses       2025     2025              
Files Changed Coverage Δ
cirq-core/cirq/devices/insertion_noise_model.py 97.22% <100.00%> (+0.67%) ⬆️
...rq-core/cirq/devices/insertion_noise_model_test.py 100.00% <100.00%> (ø)
cirq-core/cirq/json_resolver_cache.py 94.00% <100.00%> (+0.12%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Collaborator

@vtomole vtomole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vtomole vtomole enabled auto-merge (squash) September 13, 2023 16:54
@vtomole vtomole added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Sep 13, 2023
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Sep 13, 2023
@CirqBot
Copy link
Copy Markdown
Contributor

CirqBot commented Sep 13, 2023

Automerge cancelled: Unrecognized update-branch status code (403).

@CirqBot CirqBot removed the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Sep 13, 2023
@CirqBot
Copy link
Copy Markdown
Contributor

CirqBot commented Sep 13, 2023

Automerge cancelled: The automerge label was removed.

@CirqBot CirqBot removed the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Sep 13, 2023
@vtomole vtomole disabled auto-merge September 13, 2023 21:44
@vtomole vtomole enabled auto-merge (squash) September 13, 2023 21:44
@vtomole vtomole disabled auto-merge September 13, 2023 22:49
@vtomole vtomole enabled auto-merge (squash) September 13, 2023 22:50
@vtomole
Copy link
Copy Markdown
Collaborator

vtomole commented Sep 13, 2023

Auto-merge is not merging 🤔

@vtomole vtomole merged commit 432d57a into quantumlib:master Sep 14, 2023
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: S 10< lines changed <50

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make InsertionNoiseModel serializable

3 participants