Make OpIdentifier serializable for all inputs#6295
Merged
vtomole merged 8 commits intoquantumlib:masterfrom Sep 26, 2023
Merged
Make OpIdentifier serializable for all inputs#6295vtomole merged 8 commits intoquantumlib:masterfrom
OpIdentifier serializable for all inputs#6295vtomole merged 8 commits intoquantumlib:masterfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
vtomole
reviewed
Sep 21, 2023
Collaborator
|
@epelaaez Please sign the CLA |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6295 +/- ##
=======================================
Coverage 97.89% 97.89%
=======================================
Files 1104 1104
Lines 95874 95887 +13
=======================================
+ Hits 93852 93866 +14
+ Misses 2022 2021 -1
☔ View full report in Codecov by Sentry. |
vtomole
reviewed
Sep 22, 2023
vtomole
reviewed
Sep 22, 2023
vtomole
reviewed
Sep 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6292
Makes
OpIdentifierserializable for inputs that are instances of classes. For example,will output