Skip to content

Add documentation for cirq google's support for google internal gates#6301

Merged
NoureldinYosri merged 3 commits intomasterfrom
internal_gate_doc
Oct 26, 2023
Merged

Add documentation for cirq google's support for google internal gates#6301
NoureldinYosri merged 3 commits intomasterfrom
internal_gate_doc

Conversation

@NoureldinYosri
Copy link
Copy Markdown
Collaborator

No description provided.

@review-notebook-app
Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@CirqBot CirqBot added the size: M 50< lines changed <250 label Sep 25, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (455f50b) 97.89% compared to head (102dfac) 97.89%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6301   +/-   ##
=======================================
  Coverage   97.89%   97.89%           
=======================================
  Files        1108     1108           
  Lines       96210    96210           
=======================================
  Hits        94187    94187           
  Misses       2023     2023           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread docs/google/pyle_gates.ipynb Outdated
@NoureldinYosri NoureldinYosri changed the title Add documentation for InternalGate => PyleGate translation Add documentation for InternalGate => Internal translation Oct 9, 2023
@NoureldinYosri NoureldinYosri changed the title Add documentation for InternalGate => Internal translation Add documentation for InternalGate => Internal gate implementations translation Oct 9, 2023
@NoureldinYosri NoureldinYosri changed the title Add documentation for InternalGate => Internal gate implementations translation Add documentation for cirq google's support for google internal gate implementations Oct 9, 2023
@NoureldinYosri NoureldinYosri changed the title Add documentation for cirq google's support for google internal gate implementations Add documentation for cirq google's support for google internal gates Oct 9, 2023
@NoureldinYosri NoureldinYosri marked this pull request as ready for review October 25, 2023 23:22
Comment thread docs/google/internal_gates.ipynb Outdated
@dstrain115
Copy link
Copy Markdown
Collaborator

Do we need to link this doc via any TOC anywhere, cc @wcourtney ?

@NoureldinYosri
Copy link
Copy Markdown
Collaborator Author

@dstrain115 I don't think any of the cirq-google notebooks are indexed. For example https://quantumai.google/cirq/google/best_practices, https://quantumai.google/cirq/google/qubit-placement, ..etc

@NoureldinYosri NoureldinYosri enabled auto-merge (squash) October 26, 2023 18:06
@NoureldinYosri NoureldinYosri enabled auto-merge (squash) October 26, 2023 18:06
@NoureldinYosri NoureldinYosri merged commit 235a0c6 into master Oct 26, 2023
@NoureldinYosri NoureldinYosri deleted the internal_gate_doc branch October 26, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: M 50< lines changed <250

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants