Break intermediate measurements on 3+ qubits into single qubit measurements in RouteCQC#6293#6349
Merged
NoureldinYosri merged 24 commits intomasterfrom Nov 27, 2023
unknown repository
Merged
Break intermediate measurements on 3+ qubits into single qubit measurements in RouteCQC#6293#6349NoureldinYosri merged 24 commits intomasterfrom unknown repository
RouteCQC#6293#6349NoureldinYosri merged 24 commits intomasterfrom
unknown repository
Conversation
updat with latest version
Allow specifying settings field from Cirq-ionq (#5817)
Developer enviroment guideline update
updating forked repo
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6349 +/- ##
=======================================
Coverage 97.84% 97.84%
=======================================
Files 1110 1110
Lines 96690 96706 +16
=======================================
+ Hits 94606 94622 +16
Misses 2084 2084 ☔ View full report in Codecov by Sentry. |
on 3+ qubits into single qubit measurements if -and only if- the result isn't stored (i.e. key is None) and test for changes in RoutCQC
ghost
marked this pull request as ready for review
ghost
changed the title
RouteCQC#6293
ghost
commented
Nov 17, 2023
NoureldinYosri
requested changes
Nov 17, 2023
Collaborator
NoureldinYosri
left a comment
NoureldinYosri
left a comment
There was a problem hiding this comment.
please remove changes to unrelated files
removed unintended change
NoureldinYosri
requested changes
Nov 17, 2023
updates from review- varible names, ciruit build
ghost
commented
Nov 17, 2023
NoureldinYosri
requested changes
Nov 17, 2023
Collaborator
NoureldinYosri
left a comment
NoureldinYosri
left a comment
There was a problem hiding this comment.
just a few more nits + please fix the conflict with the main branch
NoureldinYosri
requested changes
Nov 27, 2023
Collaborator
NoureldinYosri
left a comment
NoureldinYosri
left a comment
There was a problem hiding this comment.
almost there. one small change
| operation = ( | ||
| 'Intermediate measurements on three or more qubits with a custom key' | ||
| ) | ||
| raise ValueError(f'Unsupported operation: {operation}') |
Collaborator
There was a problem hiding this comment.
raise ValueError('Intermediate measurements on three or more qubits with a custom key are not supported')if this line is too long you can break it into two string literals
raise ValueError('Intermediate measurements on three or more qubits '
'with a custom key are not supported')
NoureldinYosri
approved these changes
Nov 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
router mishandling mid-circuit measurements #issue6293
Description of the issue
cirq.RouteCQCcommutes gates in undefined ways due to intermediate measurements with 3 or more qubits not being handled correctly.This PR aims to fix this issue by:
Breaking intermediate measurements on 3+ qubits into single qubit measurements if the result isn't stored (i.e. key is None) else a
ValueErroris raised.Next Steps
Check if it's possible to create a ClassicallyControlledOperation controlled by the result of a multiqubit measurement
From looking at the documentation it seems to be possible. Will stop here until there is a need to support this case.