Remove dummy from cirq-core#6356
Merged
dstrain115 merged 2 commits intoquantumlib:masterfrom Nov 22, 2023
Merged
Conversation
Collaborator
dstrain115
commented
Nov 21, 2023
dstrain115
commented
- Latest best practice advice is to remove all mentions of the word 'dummy' as it is problematic terminology.
- Latest best practice advice is to remove all mentions of the word 'dummy' as it is problematic terminology.
dstrain115
requested review from
a team,
cduck,
mrwojtek and
vtomole
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6356 +/- ##
==========================================
- Coverage 97.84% 97.84% -0.01%
==========================================
Files 1110 1110
Lines 96696 96696
==========================================
- Hits 94612 94608 -4
- Misses 2084 2088 +4 ☔ View full report in Codecov by Sentry. |
pavoljuhas
requested changes
Nov 21, 2023
Collaborator
pavoljuhas
left a comment
pavoljuhas
left a comment
There was a problem hiding this comment.
Nice. There are however still some dummy-named classes in test modules:
$ git grep -i '(class|def) .*dummy' cirq-core
cirq-core/cirq/circuits/qasm_output_test.py:251: class DummyOperation(cirq.Operation):
...
I can help with those if needed.
Collaborator
Author
|
@pavoljuhas Added a bunch more references, PTAL, thanks! |
pavoljuhas
approved these changes
Nov 22, 2023
pavoljuhas
added a commit
to pavoljuhas/Cirq
that referenced
this pull request
Nov 22, 2023
Follow up to quantumlib#6356. Replace non-inclusive terminology.
pavoljuhas
added a commit
that referenced
this pull request
Nov 28, 2023
Follow up to #6356. Replace non-inclusive terminology.
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
* Remove dummy from cirq-core - Latest best practice advice is to remove all mentions of the word 'dummy' as it is problematic terminology.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.