ProcessorSampler: route run_batch to run_sweep#6357
Merged
verult merged 2 commits intoquantumlib:masterfrom Nov 22, 2023
Merged
ProcessorSampler: route run_batch to run_sweep#6357verult merged 2 commits intoquantumlib:masterfrom
verult merged 2 commits intoquantumlib:masterfrom
Conversation
verult
requested review from
a team,
cduck,
vtomole and
wcourtney
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6357 +/- ##
=======================================
Coverage 97.84% 97.84%
=======================================
Files 1110 1110
Lines 96696 96690 -6
=======================================
- Hits 94608 94606 -2
+ Misses 2088 2084 -4 ☔ View full report in Codecov by Sentry. |
dstrain115
approved these changes
Nov 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of deprecating support for Quantum Engine batch programs, while keeping the
cirq.Sampler.run_batch()interface.cc @eliottrosenberg @wcourtney