Remote problematic terminology from test#6368
Merged
dstrain115 merged 1 commit intoquantumlib:mainfrom Dec 1, 2023
Merged
Conversation
Collaborator
dstrain115
commented
Dec 1, 2023
dstrain115
commented
- "Dude, blacklist is not the preferred nomenclature here."
- "Dude, blacklist is not the preferred nomenclature here."
viathor
approved these changes
Dec 1, 2023
|
|
||
| @pytest.mark.parametrize('mod_spec', MODULE_TEST_SPECS, ids=repr) | ||
| def test_mutually_exclusive_blacklist(mod_spec: ModuleJsonTestSpec): | ||
| def test_mutually_exclusive_lists(mod_spec: ModuleJsonTestSpec): |
Collaborator
There was a problem hiding this comment.
Optional: blocklist and passlist are self-explanatory alternatives.
Collaborator
Author
There was a problem hiding this comment.
True, but I didn't think that these were necessary. Should not serialize and not yet serialize I guess are block lists, but the term didn't really seem to fit.
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
- "Dude, blacklist is not the preferred nomenclature here."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.