Remove cached_property backport#6398
Merged
pavoljuhas merged 5 commits intoquantumlib:mainfrom Jan 11, 2024
Merged
Conversation
Josha91
requested review from
a team,
cduck,
verult,
vtomole and
wcourtney
as code owners
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
pavoljuhas
reviewed
Jan 8, 2024
pavoljuhas
approved these changes
Jan 10, 2024
Collaborator
|
@Josha91 - it seems #6392 reintroduced some cached_property calls on the main branch. Can you please replace those as well? cc: @NoureldinYosri |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6398 +/- ##
=======================================
Coverage 97.80% 97.81%
=======================================
Files 1111 1111
Lines 97088 97078 -10
=======================================
- Hits 94961 94957 -4
+ Misses 2127 2121 -6 ☔ View full report in Codecov by Sentry. |
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
We require recent-enough Python which has `functools.cached_property`. Fixes quantumlib#6395
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As described in this issue:
#6395
The backport is no longer necessary and is therefore removed.