Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6415 +/- ##
=======================================
Coverage 97.81% 97.81%
=======================================
Files 1111 1111
Lines 97078 97078
=======================================
Hits 94957 94957
Misses 2121 2121 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
@pavoljuhas following up, can't add you as a reviewer. |
And bump up the copyright year as well. Ref: https://www.sphinx-doc.org/en/master/usage/configuration.html#confval-master_doc
Remove package pinning workarounds introduced for quantumlib#6400. Also remove an old pinning of the Jinja2 package which is unlikely to be still needed.
pavoljuhas
requested changes
Jan 17, 2024
Collaborator
pavoljuhas
left a comment
pavoljuhas
left a comment
There was a problem hiding this comment.
@smburdick - I have added a few clean-up tweaks at my branch amend-pr-6415.
Please update this PR using
git pull https://github.com/pavoljuhas/Cirq.git amend-pr-6415
and it will be good to go.
Thank you for a quick response!
pavoljuhas
approved these changes
Jan 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing #6400