remove partial CZs if allow_partial_czs=False#6436
Merged
NoureldinYosri merged 9 commits intomainfrom Feb 2, 2024
Merged
Conversation
NoureldinYosri
requested review from
a team,
cduck and
vtomole
as code owners
NoureldinYosri
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6436 +/- ##
==========================================
- Coverage 97.81% 97.81% -0.01%
==========================================
Files 1111 1111
Lines 97121 97163 +42
==========================================
+ Hits 95000 95040 +40
- Misses 2121 2123 +2 ☔ View full report in Codecov by Sentry. |
dstrain115
approved these changes
Feb 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #6428
At the point where the function gets called no partial CZs should be there excpet CZ**-1 which gets replaced by CZ