Skip to content

CI - update GitHub actions to node20 #6450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pavoljuhas merged 3 commits into from
Feb 12, 2024
Merged

CI - update GitHub actions to node20 #6450

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
527d395
Bump up to actions/stale@v9 compatible with node20
pavoljuhas Feb 8, 2024
58b9e3b
Merge branch 'main' into ci-update-actions-to-node20
pavoljuhas Feb 12, 2024
b46213a
Merge branch 'main' into ci-update-actions-to-node20
pavoljuhas Feb 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/stale.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,12 @@ jobs:
stale:
runs-on: ubuntu-20.04
steps:
- uses: actions/stale@v3
- uses: actions/stale@v9
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
stale-issue-message: 'This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 30 days'
days-before-stale: 30
days-before-close: 30
close-issue-message: 'Issue closed due to inactivity.'
stale-issue-label: 'triage/stale'
exempt-issue-labels: 'triage/accepted,triage/discuss,kind/design-issue,kind/health,kind/roadmap-item,kind/task'
Copy link
Copy Markdown
Collaborator

@NoureldinYosri NoureldinYosri Feb 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is there a diff here? as far as I can see there are no changes to this line.

Copy link
Copy Markdown
Collaborator Author

@pavoljuhas pavoljuhas Feb 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vim by default fixes up missing newline at the end of file. Proper text files should end in a newline,
otherwise cat f1.txt f2.txt will have strange result.

$ git diff -U0 HEAD^2
diff --git a/.github/workflows/stale.yml b/.github/workflows/stale.yml
index c840eb08..dd7cb263 100644
--- a/.github/workflows/stale.yml
+++ b/.github/workflows/stale.yml
@@ -10 +10 @@ jobs:
-    - uses: actions/stale@v3
+    - uses: actions/stale@v9
@@ -18 +18 @@ jobs:
-        exempt-issue-labels: 'triage/accepted,triage/discuss,kind/design-issue,kind/health,kind/roadmap-item,kind/task'
\ No newline at end of file
+        exempt-issue-labels: 'triage/accepted,triage/discuss,kind/design-issue,kind/health,kind/roadmap-item,kind/task'

exempt-issue-labels: 'triage/accepted,triage/discuss,kind/design-issue,kind/health,kind/roadmap-item,kind/task'