Preserve circuit tags in transformer_primitives.map_operations#6505
Merged
Preserve circuit tags in transformer_primitives.map_operations#6505
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6505 +/- ##
=======================================
Coverage 97.76% 97.76%
=======================================
Files 1105 1105
Lines 95028 95047 +19
=======================================
+ Hits 92900 92919 +19
Misses 2128 2128 ☔ View full report in Codecov by Sentry. |
NoureldinYosri
approved these changes
Mar 18, 2024
| ) | ||
| if isinstance(target_circuit, circuits.FrozenCircuit): | ||
| return cast(CIRCUIT_TYPE, circuits.FrozenCircuit(ops).with_tags(*target_circuit.tags)) | ||
| return cast(CIRCUIT_TYPE, circuits.Circuit(ops)) |
Collaborator
There was a problem hiding this comment.
nit: do we need the cast statements?
Contributor
Author
There was a problem hiding this comment.
Yes, unfortunately we do need them. Otherwise mypy doesn't understand that the return type matches the type variable on the input arg.
| circuit = cirq.FrozenCircuit.from_moments(x, cirq.FrozenCircuit(x)).with_tags(tag) | ||
| mapped = cirq.map_operations(circuit, func, deep=deep) | ||
|
|
||
| assert circuit.tags == (tag,) |
Collaborator
There was a problem hiding this comment.
why do we check the input circuit here and below?
Contributor
Author
There was a problem hiding this comment.
They're not needed. I will remove because I agree the point is not clear.
jselig-rigetti
pushed a commit
to jselig-rigetti/Cirq
that referenced
this pull request
May 28, 2024
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6504.