display tags by str instead of repr in circuit diagrams#6530
display tags by str instead of repr in circuit diagrams#6530pavoljuhas merged 11 commits intoquantumlib:mainfrom
str instead of repr in circuit diagrams#6530Conversation
|
@richrines1 - This looks good to me considering the context of the title and considering no issues with refreshing the branch to current. Regarding implementation of |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6530 +/- ##
=======================================
Coverage 97.79% 97.79%
=======================================
Files 1124 1124
Lines 95486 95468 -18
=======================================
- Hits 93376 93359 -17
+ Misses 2110 2109 -1 ☔ View full report in Codecov by Sentry. |
pavoljuhas
left a comment
There was a problem hiding this comment.
LGTM, with a small suggestion to use map for brevity.
As for the _circuit_diagram_info_ - I feel it would be better to add in a separate PR.
Thank you for contributing this!
Co-authored-by: Pavol Juhas <pavol.juhas@gmail.com>
…ib#6530) Use more readable rendering of tagged operations in diagrams. Fixes: quantumlib#6411
…ib#6530) Use more readable rendering of tagged operations in diagrams. Fixes: quantumlib#6411
…ib#6530) Use more readable rendering of tagged operations in diagrams. Fixes: quantumlib#6411
addresses #6411
as described in this comment it might also be nice to allow tags to define their own
_circuit_diagram_info_magic method - happy to add this (either here or in a follow up) if this would be preferred