Skip to content

pin scipy to ~1.12.0 to temporarily fix ci#6545

Merged
NoureldinYosri merged 1 commit intoquantumlib:mainfrom
NoureldinYosri:ci
Apr 2, 2024
Merged

pin scipy to ~1.12.0 to temporarily fix ci#6545
NoureldinYosri merged 1 commit intoquantumlib:mainfrom
NoureldinYosri:ci

Conversation

@NoureldinYosri
Copy link
Copy Markdown
Collaborator

context: #6543

@NoureldinYosri NoureldinYosri requested review from a team, cduck and vtomole as code owners April 2, 2024 22:37
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.78%. Comparing base (f955650) to head (426de3c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6545   +/-   ##
=======================================
  Coverage   97.78%   97.78%           
=======================================
  Files        1107     1107           
  Lines       95182    95182           
=======================================
  Hits        93073    93073           
  Misses       2109     2109           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Collaborator

@pavoljuhas pavoljuhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@NoureldinYosri NoureldinYosri merged commit acb7bf8 into quantumlib:main Apr 2, 2024
@BichengYing
Copy link
Copy Markdown
Collaborator

@NoureldinYosri @pavoljuhas I have a conflict of using cirq with pyle on scipy version. Can we just modify it into scipy < 1.13?

  SolverProblemError

  Because pyle depends on cirq-core (1.4.0.dev20240404120310) which depends on scipy (>=1.12.0,<1.13.0), scipy is required.
  So, because pyle depends on scipy (~1.9.2), version solving failed.

pavoljuhas pushed a commit that referenced this pull request Apr 4, 2024
In order to avoid the conflict of requirement specs for packages that need older scipy
just require that scipy is pinned to versions before 1.13.

For previous context for scipy ~=1.12 see #6545 and #6543
jselig-rigetti pushed a commit to jselig-rigetti/Cirq that referenced this pull request May 28, 2024
jselig-rigetti pushed a commit to jselig-rigetti/Cirq that referenced this pull request May 28, 2024
In order to avoid the conflict of requirement specs for packages that need older scipy
just require that scipy is pinned to versions before 1.13.

For previous context for scipy ~=1.12 see quantumlib#6545 and quantumlib#6543
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
In order to avoid the conflict of requirement specs for packages that need older scipy
just require that scipy is pinned to versions before 1.13.

For previous context for scipy ~=1.12 see quantumlib#6545 and quantumlib#6543
BichengYing added a commit to BichengYing/Cirq that referenced this pull request Jun 20, 2025
In order to avoid the conflict of requirement specs for packages that need older scipy
just require that scipy is pinned to versions before 1.13.

For previous context for scipy ~=1.12 see quantumlib#6545 and quantumlib#6543
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants