Skip to content

Set maxsize of request queue to Quantum Engine#6576

Merged
senecameeks merged 3 commits intoquantumlib:mainfrom
senecameeks:u/smeeks/add_backpressure
Apr 30, 2024
Merged

Set maxsize of request queue to Quantum Engine#6576
senecameeks merged 3 commits intoquantumlib:mainfrom
senecameeks:u/smeeks/add_backpressure

Conversation

@senecameeks
Copy link
Copy Markdown
Collaborator

@senecameeks senecameeks commented Apr 25, 2024

We want to prevent overwhelming the engine tasks with too many requests.

Setting a maxsize does not reject requests that happen after the queue is full. Instead, when a request is to be put into the queue it will wait until a free slot is available before adding.

We also limit the size of the request messages sent to prevent overloading the server with very large requests.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.79%. Comparing base (2474d47) to head (fc4c293).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6576   +/-   ##
=======================================
  Coverage   97.79%   97.79%           
=======================================
  Files        1124     1124           
  Lines       95658    95659    +1     
=======================================
+ Hits        93549    93550    +1     
  Misses       2109     2109           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@senecameeks senecameeks marked this pull request as ready for review April 30, 2024 17:00
@senecameeks senecameeks requested review from a team, cduck, verult, vtomole and wcourtney as code owners April 30, 2024 17:00
@senecameeks senecameeks merged commit 614c78a into quantumlib:main Apr 30, 2024
jselig-rigetti pushed a commit to jselig-rigetti/Cirq that referenced this pull request May 28, 2024
* set maxsize for request queue

* add max message size
BichengYing pushed a commit to BichengYing/Cirq that referenced this pull request Jun 20, 2025
* set maxsize for request queue

* add max message size
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants