enable simulation of controlled gates in classical simulator#6589
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6589 +/- ##
=======================================
Coverage 97.81% 97.81%
=======================================
Files 1063 1063
Lines 91761 91796 +35
=======================================
+ Hits 89755 89793 +38
+ Misses 2006 2003 -3 ☔ View full report in Codecov by Sentry. |
NoureldinYosri
left a comment
There was a problem hiding this comment.
thanks for noticing this and offering to help, I left a couple of comments
NoureldinYosri
left a comment
There was a problem hiding this comment.
one more thing + CI
|
whoops, I realized why I wasn't seeing the linter errors locally---I was mistaken about what running |
NoureldinYosri
left a comment
There was a problem hiding this comment.
@GregDMeyer thanks for your contribution. great work
Currently, only X, CNOT, TOFFOLI, SWAP, and measurement are supported by
cirq.ClassicalStateSimulator. This pull request adds support for versions of the first four gates with an arbitrary number of controls (as generated by the.controlled()function).