Partial Support for tags in cirq_google protos#7044
Merged
dstrain115 merged 8 commits intoquantumlib:mainfrom Feb 11, 2025
Merged
Partial Support for tags in cirq_google protos#7044dstrain115 merged 8 commits intoquantumlib:mainfrom
dstrain115 merged 8 commits intoquantumlib:mainfrom
Conversation
- This adds several tags to cirq_google protos, and also adds partial support for serialization and deserialization of tags. Note: still pending are arguments for InternalTag objects and better ability to serialize/deserialize internal tags that are not public.
dstrain115
requested review from
a team,
verult,
vtomole and
wcourtney
as code owners
pavoljuhas
reviewed
Feb 8, 2025
pavoljuhas
reviewed
Feb 8, 2025
| msg = program_pb2.Tag() | ||
| msg.internal_tag.tag_name = self.name | ||
| msg.internal_tag.tag_package = self.package | ||
| # for k, v in self.tag_args.items(): |
Collaborator
There was a problem hiding this comment.
I guess this is left for a follow-up PR?
Collaborator
Author
There was a problem hiding this comment.
Yes, removed. Probably needs a refactor since it introduces a circular dependency.
Co-authored-by: Pavol Juhas <pavol.juhas@gmail.com>
Co-authored-by: Pavol Juhas <pavol.juhas@gmail.com>
Co-authored-by: Pavol Juhas <pavol.juhas@gmail.com>
Co-authored-by: Pavol Juhas <pavol.juhas@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7044 +/- ##
========================================
Coverage 98.17% 98.17%
========================================
Files 1087 1087
Lines 94724 94840 +116
========================================
+ Hits 92993 93110 +117
+ Misses 1731 1730 -1 ☔ View full report in Codecov by Sentry. |
pavoljuhas
approved these changes
Feb 10, 2025
BichengYing
pushed a commit
to BichengYing/Cirq
that referenced
this pull request
Jun 20, 2025
* Partial Support for tags in cirq_google protos - This adds several tags to cirq_google protos, and also adds partial support for serialization and deserialization of tags. Note: still pending are arguments for InternalTag objects and better ability to serialize/deserialize internal tags that are not public. * Update cirq-google/cirq_google/ops/fsim_via_model_tag.py Co-authored-by: Pavol Juhas <pavol.juhas@gmail.com> * Update cirq-google/cirq_google/ops/physical_z_tag.py Co-authored-by: Pavol Juhas <pavol.juhas@gmail.com> * Update cirq-google/cirq_google/ops/internal_tag.py Co-authored-by: Pavol Juhas <pavol.juhas@gmail.com> * Update cirq-google/cirq_google/serialization/circuit_serializer.py Co-authored-by: Pavol Juhas <pavol.juhas@gmail.com> * Address some comments. * Address other comment. * Solve all the CI problems. --------- Co-authored-by: Pavol Juhas <pavol.juhas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: still pending are arguments for InternalTag objects and better ability to serialize/deserialize internal tags that are not public.