Fix the format of CliffordGate repr.#7046
Merged
pavoljuhas merged 7 commits intoquantumlib:mainfrom Feb 12, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7046 +/- ##
=======================================
Coverage 98.18% 98.18%
=======================================
Files 1089 1089
Lines 95201 95208 +7
=======================================
+ Hits 93471 93478 +7
Misses 1730 1730 ☔ View full report in Codecov by Sentry. |
dstrain115
approved these changes
Feb 9, 2025
pavoljuhas
approved these changes
Feb 10, 2025
pavoljuhas
reviewed
Feb 12, 2025
pavoljuhas
reviewed
Feb 12, 2025
Collaborator
pavoljuhas
left a comment
pavoljuhas
left a comment
There was a problem hiding this comment.
The unit test should compare with a constant expected string. Otherwise LGTM.
Collaborator
Author
|
Updated the code, I will hold this PR for reivew, if it looks good, I will submit tomorrow afternoon. |
pavoljuhas
reviewed
Feb 12, 2025
pavoljuhas
approved these changes
Feb 12, 2025
Collaborator
pavoljuhas
left a comment
pavoljuhas
left a comment
There was a problem hiding this comment.
LGTM, thank you for fixing this!
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
BichengYing
pushed a commit
to BichengYing/Cirq
that referenced
this pull request
Jun 20, 2025
* fix the format of CliffordGate repr. * Add unit tests for CliffordGate.__repr__() * Check the full string of repr without calling _str_full_. * remove test cases * Strip trailing blanks in the expected repr(gate) string --------- Co-authored-by: Pavol Juhas <juhas@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove one space to align output CliffordTableau correctly.
Before:
After: