Improve the readability of CliffordTableau _full_str_ function#7047
Merged
pavoljuhas merged 7 commits intoquantumlib:mainfrom Feb 12, 2025
Merged
Improve the readability of CliffordTableau _full_str_ function#7047pavoljuhas merged 7 commits intoquantumlib:mainfrom
pavoljuhas merged 7 commits intoquantumlib:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7047 +/- ##
==========================================
- Coverage 98.18% 98.17% -0.01%
==========================================
Files 1089 1089
Lines 95202 95201 -1
==========================================
- Hits 93473 93468 -5
- Misses 1729 1733 +4 ☔ View full report in Codecov by Sentry. |
babacry
changed the title
pavoljuhas
reviewed
Feb 10, 2025
| def test_str_full(): | ||
| t = cirq.CliffordTableau(num_qubits=1) | ||
| expected_str = r"""stable | destable | ||
| expected_str = r"""stable | destable |
Collaborator
There was a problem hiding this comment.
Please, do not introduce trailing blanks. The output is more usable without them.
pavoljuhas
reviewed
Feb 10, 2025
Comment on lines
+305
to
+303
| """ | ||
| + Z0 | + Y0 """ |
Collaborator
There was a problem hiding this comment.
Please keep the newline at the end of the string.
There might be a user code that relies on its presence.
pavoljuhas
reviewed
Feb 10, 2025
Comment on lines
+337
to
+338
| return { | ||
| (True, False): f'X{c}', |
Collaborator
There was a problem hiding this comment.
Please rewrite using match-case statement - https://docs.python.org/3/whatsnew/3.10.html#patterns-with-a-literal-and-variable. Should be more readable and avoid a temporary dictionary for each Pauli symbol resolution.
pavoljuhas
reviewed
Feb 10, 2025
| fill_row( | ||
| left='{sign} {paulis}'.format( # from row i+n | ||
| sign='-' if self.rs[i + self.n] else '+', | ||
| paulis=''.join([pauli_from_matrix(i + self.n, j) for j in range(self.n)]), |
Collaborator
There was a problem hiding this comment.
no need for temporary list -
Suggested change
| paulis=''.join([pauli_from_matrix(i + self.n, j) for j in range(self.n)]), | |
| paulis=''.join(pauli_from_matrix(i + self.n, j) for j in range(self.n)), |
pavoljuhas
reviewed
Feb 10, 2025
| ), | ||
| right=' {sign} {paulis}'.format( # from row i | ||
| sign='-' if self.rs[i] else '+', | ||
| paulis=''.join([pauli_from_matrix(i, j) for j in range(self.n)]), |
Collaborator
There was a problem hiding this comment.
Suggested change
| paulis=''.join([pauli_from_matrix(i, j) for j in range(self.n)]), | |
| paulis=''.join(pauli_from_matrix(i, j) for j in range(self.n)), |
pavoljuhas
requested changes
Feb 10, 2025
Collaborator
pavoljuhas
left a comment
pavoljuhas
left a comment
There was a problem hiding this comment.
Please see inline comments.
babacry
force-pushed
the
clifford_tab
branch
from
320b3f7 to
02437f2
Compare
Collaborator
Author
|
Thanks for the comments, Pavol! done updating the pr with appended commits. |
babacry
force-pushed
the
clifford_tab
branch
from
25023ee to
7ccfd32
Compare
Avoid possibility of unmatched values, because bool can return only the `True` or `False` singletons.
We can appease pylint without line exception.
pavoljuhas
approved these changes
Feb 12, 2025
Collaborator
Author
|
LGTM, thanks! |
BichengYing
pushed a commit
to BichengYing/Cirq
that referenced
this pull request
Jun 20, 2025
…umlib#7047) * Improve the readability of Tableau str. * Apply comments. * Fix coverage * Nit - rename internal functions to start with underscore * Fix matching of np.bool values by converting them to stock bool Avoid possibility of unmatched values, because bool can return only the `True` or `False` singletons. * Rewrite string formatting with f-string We can appease pylint without line exception. --------- Co-authored-by: Pavol Juhas <juhas@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Came across this and figure improve the readability could potentially be helpful in future developments.