Make small fixes to linalg.decompositions#7128
Merged
NoureldinYosri merged 2 commits intoquantumlib:mainfrom Mar 12, 2025
Merged
Make small fixes to linalg.decompositions#7128NoureldinYosri merged 2 commits intoquantumlib:mainfrom
NoureldinYosri merged 2 commits intoquantumlib:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7128 +/- ##
=======================================
Coverage 98.16% 98.17%
=======================================
Files 1093 1093
Lines 95420 95441 +21
=======================================
+ Hits 93665 93695 +30
+ Misses 1755 1746 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
I created this PR while reading the beautiful su2xsu2->so4 homomorphism implementaion. Just cosmetic changes to improve the healthiness of the codebase. @NoureldinYosri @pavoljuhas @dstrain115 , wonder how can I properly add reviewers for this =) given that the auto assigned reviewers might be out of date? |
NoureldinYosri
approved these changes
Mar 12, 2025
Collaborator
NoureldinYosri
left a comment
There was a problem hiding this comment.
great work @babacry , thanks for catching this
BichengYing
pushed a commit
to BichengYing/Cirq
that referenced
this pull request
Jun 20, 2025
* Small fixes of linalg.decomposition. * fix lint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.