Allow cirq-google installation with protobuf-5#7147
Merged
pavoljuhas merged 1 commit intoquantumlib:mainfrom Mar 17, 2025
Merged
Allow cirq-google installation with protobuf-5#7147pavoljuhas merged 1 commit intoquantumlib:mainfrom
pavoljuhas merged 1 commit intoquantumlib:mainfrom
Conversation
Unit tests pass with protobuf-5.29.3 (latest in the 5.x series). Python protobuf sources are still generated with protobuf-4 so cirq-google can be used in environments with protobuf-4 too. Related to quantumlib#7145
pavoljuhas
requested review from
a team,
verult,
vtomole and
wcourtney
as code owners
maffoo
approved these changes
Mar 17, 2025
Contributor
maffoo
left a comment
maffoo
left a comment
There was a problem hiding this comment.
LGTM. OOC, is there a problem with protobuf 6, or are you just being conservtive about the version constraint here?
Collaborator
Author
Just conservative about major version bump. Also, I did not test with protobuf-6. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7147 +/- ##
=======================================
Coverage 98.13% 98.13%
=======================================
Files 1093 1093
Lines 95528 95528
=======================================
Hits 93746 93746
Misses 1782 1782 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
BichengYing
pushed a commit
to BichengYing/Cirq
that referenced
this pull request
Jun 20, 2025
Unit tests pass with protobuf-5.29.3 (latest in the 5.x series). Python protobuf sources are still generated with protobuf-4 so cirq-google can be used in environments with protobuf-4 too. Related to quantumlib#7145 Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unit tests pass with protobuf-5.29.3 (latest in the 5.x series).
Python protobuf sources are still generated with protobuf-4
so cirq-google can be used in environments with protobuf-4 too.
Related to #7145