Add missing license headers & do minor updates to top-level dot files#7161
Merged
mhucka merged 9 commits intoquantumlib:mainfrom Mar 21, 2025
Merged
Add missing license headers & do minor updates to top-level dot files#7161mhucka merged 9 commits intoquantumlib:mainfrom
mhucka merged 9 commits intoquantumlib:mainfrom
Conversation
Apparently I misread guidance somewhere, and license headers are required for these sorts of files after all.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7161 +/- ##
==========================================
- Coverage 98.13% 98.13% -0.01%
==========================================
Files 1093 1093
Lines 95579 95579
==========================================
- Hits 93798 93797 -1
- Misses 1781 1782 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pavoljuhas
requested changes
Mar 19, 2025
Collaborator
pavoljuhas
left a comment
pavoljuhas
left a comment
There was a problem hiding this comment.
Please see inline comments.
This removes unnecessary or unused content, in response to review comments on PR quantumlib#7161.
Contributor
Author
|
@Pavol the latest update address all the points, but does not add max_line_length yet, pending a resolution to our off-line discussion about what to do with that setting. |
After more discussion, the conclusion is that despite the issues with `max_line_length`, it is handled as expected in the editors that many people have been using.
Collaborator
|
This patch resolves typescript lint check. The typescript linter looks at max_line_length and if active wants to reformat sources. That can be done later. diff --git a/.editorconfig b/.editorconfig
index 97b035e1..b45c549c 100644
--- a/.editorconfig
+++ b/.editorconfig
@@ -38,4 +38,5 @@ max_line_length = 100
# Google style guidelines use 2.
indent_size = 2
+max_line_length = 0
[*.json]
|
Contributor
Author
I'm curious: how did you figure this out? |
The typescript linter looks at max_line_length and takes it into account if it finds a value. This is causing CI checks to fail. We need to reformat the sources in question and then we can remove this setting again
Collaborator
I ran |
pavoljuhas
approved these changes
Mar 20, 2025
mhucka
changed the title
BichengYing
pushed a commit
to BichengYing/Cirq
that referenced
this pull request
Jun 20, 2025
…#7161) * Add missing license headers Apparently I misread guidance somewhere, and license headers are required for these sorts of files after all. * Revise to address comments in review This removes unnecessary or unused content, in response to review comments on PR quantumlib#7161. * Change copyright to refer to Cirq Developers * Add back max_line_length setting After more discussion, the conclusion is that despite the issues with `max_line_length`, it is handled as expected in the editors that many people have been using. * Change copyright to refer to Cirq Developers * Add temp max_line_length value for TS linter The typescript linter looks at max_line_length and takes it into account if it finds a value. This is causing CI checks to fail. We need to reformat the sources in question and then we can remove this setting again * Shorten the file header --------- Co-authored-by: Pavol Juhas <juhas@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After discovering this week that Google's requirements for license headers are not what I originally thought (tl;dr: they're actually needed everywhere), I'm going around and adding them to files where I failed to put them before. Poor use of time, but seems necessary.
While at it, for files like
.editorconfig, I'm updating them slightly to match the conclusions from recent discussions.