Edit examples/README.md to clarify the license terms for the code in examples/*#7173
Merged
mhucka merged 2 commits intoquantumlib:mainfrom Mar 21, 2025
Merged
Conversation
The statement about everyone being free to copy, publish, etc., was ambiguous; after discussion with @Dstrain, we settled on adding mention of the Apache license. While I was at it, I got rid of my previous hacky solution to highlighting the note in favor of using GFM's markup.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7173 +/- ##
==========================================
- Coverage 98.13% 98.13% -0.01%
==========================================
Files 1095 1095
Lines 95649 95649
==========================================
- Hits 93867 93866 -1
- Misses 1782 1783 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pavoljuhas
reviewed
Mar 21, 2025
Co-authored-by: Pavol Juhas <pavol.juhas@gmail.com>
pavoljuhas
approved these changes
Mar 21, 2025
Collaborator
pavoljuhas
left a comment
pavoljuhas
left a comment
There was a problem hiding this comment.
LGTM with a fixed URL
mhucka
changed the title
BichengYing
pushed a commit
to BichengYing/Cirq
that referenced
this pull request
Jun 20, 2025
* Clarify the license statement for examples/ The statement about everyone being free to copy, publish, etc., was ambiguous; after discussion with @Dstrain, we settled on adding mention of the Apache license. While I was at it, I got rid of my previous hacky solution to highlighting the note in favor of using GFM's markup. * Update examples/README.md Co-authored-by: Pavol Juhas <pavol.juhas@gmail.com> --------- Co-authored-by: Pavol Juhas <pavol.juhas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The statement about everyone being free to copy, publish, etc., was ambiguous; after discussion with @Dstrain, we settled on adding mention of the Apache license.
While I was at it, I got rid of my previous hacky solution for formatting the note, in favor of using GFM's simple markup for info boxes.