Skip to content

Avoid frequent test failure in greedy_test.py by increasing timeout #7188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mhucka merged 2 commits into from
Mar 26, 2025
Merged

Avoid frequent test failure in greedy_test.py by increasing timeout #7188

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a1c9e6f
Fix frequent test failure in greedy_test.py
mhucka Mar 26, 2025
428433c
Update docstring to match change in code
mhucka Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cirq-core/cirq/contrib/routing/greedy_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,11 @@ def create_hanging_routing_instance(circuit, device_graph):


def test_router_hanging():
"""Run a separate process and check if greedy router hits timeout (5s)."""
"""Run a separate process and check if greedy router hits timeout (20s)."""
circuit, device_graph = create_circuit_and_device()
process = Process(target=create_hanging_routing_instance, args=[circuit, device_graph])
process.start()
process.join(timeout=5)
process.join(timeout=20)
Copy link
Copy Markdown
Collaborator

@viathor viathor Mar 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update docstring on line 52 above.

Copy link
Copy Markdown
Contributor Author

@mhucka mhucka Mar 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. Thanks!

try:
assert not process.is_alive(), "Greedy router timeout"
finally:
Expand Down