Sort import statements - no change in the effective code

[pavoljuhas]

Executed check/format-incremental --all --apply

Related to #4863

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.14%. Comparing base (0f652e1) to head (1d7b889).
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7195      +/-   ##
==========================================
- Coverage   98.14%   98.14%   -0.01%     
==========================================
  Files        1100     1100              
  Lines       96191    96146      -45     
==========================================
- Hits        94409    94363      -46     
- Misses       1782     1783       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[daxfohl]

Anything in https://github.com/quantumlib/Cirq/blob/main/docs/dev/development.md or https://github.com/quantumlib/Cirq/blob/main/docs/dev/style.md that should be updated? I didn't see anything offhand for this, but I didn't look that closely. (The type annotations section will have to be updated as part of the unquoting project though.)

[mhucka]

Anything in main/docs/dev/development.md or main/docs/dev/style.md that should be updated? I didn't see anything offhand for this, but I didn't look that closely. (The type annotations section will have to be updated as part of the unquoting project though.)

Good question.

I have a PR waiting in the wings (#7175) so if any changes are needed, it would be better to coordinate (or merge the PR and then do another set of changes for this issue).

[mhucka]

I took a look just now too. In docs/dev/development.md, I think the text in "Continuous integration and local testing", which mentions using format-incremental, is probably enough for that.

For docs/dev/style.md, I think it would make sense to add some words about sorting imports in the section on 'Import statements". @pavoljuhas I could do that in PR #7175 or you could do that as part of this PR – what would be best?

[mhucka]

LGTM, with a minor question about whether some text should be added to docs/dev/style.md as part of this PR.

[pavoljuhas]

LGTM, with a minor question about whether some text should be added to docs/dev/style.md as part of this PR.

I think it is better to update style.md in a separate PR. Here it would be hidden between 600+ modified files; it is also better to keep this change all tool generated only.

Thanks for a quick review!

[mhucka]

I think it is better to update style.md in a separate PR. Here it would be hidden between 600+ modified files; it is also better to keep this change all tool generated only.

@pavoljuhas I added some text to PR #7175, specifically in commit 83cdba6. Hopefully the changes are clear and accurate.