Skip to content

Improve check of expected shell commands in check/format-incremental #7196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mhucka merged 1 commit into from
Mar 27, 2025
Merged

Improve check of expected shell commands in check/format-incremental #7196

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion dev_tools/bash_scripts_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -573,9 +573,12 @@ def test_incremental_format_branch_selection(tmpdir_factory):
'git checkout -q alt\n'
'echo " print(1)" > alt.py\n'
'git add -A\n'
'git commit -q -m test3 --no-gpg-sign\n',
'git commit -q -m test3 --no-gpg-sign\n'
'export CI=true\n',
additional_intercepts=['isort'],
)
assert result.returncode == 0
assert 'INTERCEPTED isort --color --check --diff alt.py' in result.stdout
assert 'INTERCEPTED black --color --check --diff alt.py' in result.stdout
assert result.stderr.startswith("Comparing against revision 'main' (merge base ")

Expand Down