Merged
Conversation
- This either adds tests or "pragma: nocover" for all uncovered lines in cirq. - Most of it is overloads, not implemented methods, or test objects. - However, a few things were missing tests. Fixes: quantumlib#3939
dstrain115
requested review from
a team,
mrwojtek,
verult,
vtomole and
wcourtney
as code owners
Collaborator
|
The magic comment should be
done in 7b1c765 |
pavoljuhas
approved these changes
Apr 3, 2025
Collaborator
pavoljuhas
left a comment
pavoljuhas
left a comment
There was a problem hiding this comment.
LGTM if the tests pass. Please check if you are OK with my updates.
Co-authored-by: Pavol Juhas <pavol.juhas@gmail.com>
…Cirq-1 into fix_all_the_coverage
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7220 +/- ##
==========================================
+ Coverage 98.15% 98.66% +0.50%
==========================================
Files 1100 1106 +6
Lines 96253 95864 -389
==========================================
+ Hits 94473 94580 +107
+ Misses 1780 1284 -496 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pavoljuhas
added a commit
to pavoljuhas/Cirq
that referenced
this pull request
Apr 3, 2025
Let us avoid test-only argument in `circuit_to_pdf_using_qcircuit_via_tex`. Also check if PDF is generated and auxiliary files are cleaned. Related to quantumlib#7220
pavoljuhas
added a commit
to pavoljuhas/Cirq
that referenced
this pull request
Apr 4, 2025
Let us avoid test-only argument in `circuit_to_pdf_using_qcircuit_via_tex`. Mock `Document.generate_pdf` so we can test without the `latexmk` program. Related to quantumlib#7220
pavoljuhas
added a commit
to pavoljuhas/Cirq
that referenced
this pull request
Apr 4, 2025
Let us avoid test-only argument in `circuit_to_pdf_using_qcircuit_via_tex`. Mock `Document.generate_pdf` so we can test without the `latexmk` program. Related to quantumlib#7220
This was referenced May 30, 2025
BichengYing
pushed a commit
to BichengYing/Cirq
that referenced
this pull request
Jun 20, 2025
* Fix ALL THE COVERAGE - This either adds tests or "pragma: nocover" for all uncovered lines in cirq. - Most of it is overloads, not implemented methods, or test objects. - However, a few things were missing tests. Fixes: quantumlib#3939 * Use coverage exclusion comment `# pragma: no cover` Ref: https://coverage.readthedocs.io/en/latest/excluding.html * Exclude coverage of the `pass` statement by default * Exclude coverage of `raise NotImplementedError` by default * Fix qcircuit pdf coverage * Update cirq-core/cirq/experiments/random_quantum_circuit_generation.py Co-authored-by: Pavol Juhas <pavol.juhas@gmail.com> * format --------- Co-authored-by: Pavol Juhas <juhas@google.com> Co-authored-by: Pavol Juhas <pavol.juhas@gmail.com>
BichengYing
pushed a commit
to BichengYing/Cirq
that referenced
this pull request
Jun 20, 2025
…uantumlib#7227) Let us avoid test-only argument in `circuit_to_pdf_using_qcircuit_via_tex`. Mock `Document.generate_pdf` so we can test without the `latexmk` program. Related to quantumlib#7220
This was referenced Aug 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #3939